Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scam NFT Transactions Displaying in Transaction History #5394

Closed
tolltalcrypto opened this issue Oct 3, 2023 · 2 comments
Closed

Scam NFT Transactions Displaying in Transaction History #5394

tolltalcrypto opened this issue Oct 3, 2023 · 2 comments
Assignees
Labels
needs engineering Requires engineering input before bounty nice to have mayyyybe one day

Comments

@tolltalcrypto
Copy link
Member

Overview

Nice to Have - Filtering out scam NFT receives from the transaction history so if someone's wallet is getting hit hard with scam nfts, they dont have to sift through a bunch of recieced scam nft transactions. Demo wallet has 4 received at the top of the transaction history currently.
image

References and additional details

https://app.shapeshift.com/#/demo

Acceptance Criteria

Nice to Have - Filter Out Scam NFT receives in transaction history like we are preventing them from showing on the NFT Page.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@tolltalcrypto tolltalcrypto added needs engineering Requires engineering input before bounty nice to have mayyyybe one day labels Oct 3, 2023
@gomesalexandre gomesalexandre self-assigned this Oct 4, 2023
@gomesalexandre
Copy link
Contributor

@tolltalcrypto this should see large improvements after the recent Tx history improvements that went in develop, could you confirm? 🙏🏽

@kaladinlight
Copy link
Contributor

@tolltalcrypto as per @gomesalexandre comment, there were updates to this a few months back that should have made a large improvement. The filtering is based on url strings as the most dangerous scam assets, but it is difficult to catch everything with a regex. Feel free to compile a list of existing scammy assets if we want to improve coverage, but the app should be in a much better state as it stands. Closing at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty nice to have mayyyybe one day
Projects
None yet
Development

No branches or pull requests

3 participants