Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot transact with 1Inch wallet connected via Wallet Connect #5421

Closed
2 tasks done
MBMaria opened this issue Oct 5, 2023 · 1 comment · Fixed by #5425 or #5426
Closed
2 tasks done

Cannot transact with 1Inch wallet connected via Wallet Connect #5421

MBMaria opened this issue Oct 5, 2023 · 1 comment · Fixed by #5425 or #5426
Assignees
Labels
needs engineering Requires engineering input before bounty
Milestone

Comments

@MBMaria
Copy link

MBMaria commented Oct 5, 2023

Overview

1inch can connect to wallet connect as a wallet but when you try to do a tx, shapeshift app gives an error before getting the chance to sign in the 1inch wallet.

References and additional details

  1. Log into app.shapeshift.com and select Wallet Connect
  2. Connect 1inch wallet to Wallet Connect
  3. Try to do a send or trade and an error comes up straight away
    send:
    image
    image
    trade:
    image
    image

Acceptance Criteria

Should be able to use 1inch connected via WC

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added the needs engineering Requires engineering input before bounty label Oct 5, 2023
@MBMaria MBMaria added this to the wc milestone Oct 5, 2023
@woodenfurniture woodenfurniture moved this from To schedule to In progress in ShapeShift Dashboard Oct 5, 2023
@woodenfurniture woodenfurniture moved this from In progress to Up next in ShapeShift Dashboard Oct 5, 2023
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Oct 5, 2023
@woodenfurniture
Copy link
Member

We've investigated this issue, and have found the following:

All mainnet trades are working when connected via 1inch android app, but not iOS app
Non-mainnet trades fail.

Occasionally seeing an issue where 1inch wallet is able to scan a barcode but cannot connect to shapeshift, reloading 1inch mobile app resolves the issue.

After connecting 1inch wallet to shapeshift, the mobile app shows 0 conections in wallet options next to walletconnect until you close and re-open the wallet options.

The request to trade on avalanche is pushing an ethereum request to 1inch wallet

1inch wallet via walletconnect

ERC20 allowance approvals on mainnet - android ✅, iOS ❌
ERC20 -> ERC20 trade on mainnet - android ✅, iOS ❌
ETH -> ERC20 trade on mainnet - android ✅, iOS ❌
ERC20 -> ETH trade on mainnet - android ✅, iOS ❌

ERC20 allowance approvals on avalanche - android ❌ results in approval TX being sent on mainnet instead of avalanche chain https://etherscan.io/tx/0x060c033ac8e8ebd416125e0ff7b20c4b1fa5d6c711885b72df9712d0e1ac73f7
ERC20 -> ERC20 trade on avalanche - android ❌ INTERNAL_ERROR: IntrinsicGas
AVAX -> ERC20 trade on avalanche - android ❌ INTERNAL_ERROR: IntrinsicGas
ERC20 -> AVAX trade on avalanche - android ❌ INTERNAL_ERROR: IntrinsicGas

ERC20 allowance approvals on optimism - android ❌ results in approval request appearing as scam in inch wallet app. This is due to the tx being sent or received on eth mainnet instead of optimism chain:
image
image

Tested on trust wallet and seeing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty
Projects
Archived in project
2 participants