Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit orders - empty price is allowed #8415

Closed
gomesalexandre opened this issue Dec 19, 2024 · 0 comments · Fixed by #8418
Closed

Limit orders - empty price is allowed #8415

gomesalexandre opened this issue Dec 19, 2024 · 0 comments · Fixed by #8418
Assignees
@gomesalexandre
Labels
limit orders

Comments

@gomesalexandre
Copy link
Contributor

Overview

Currently in limit orders, it is possible to input an empty limit price

image image

Explicit 0 is also allowed:

image

References and additional details

N/A

Acceptance Criteria

  • Empty string/0 results in disabled confirm button

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
limit orders
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: limit orders don't let users preview with zero'd out limit price shapeshift/web
1 participant
@gomesalexandre