New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ineffective guard clauses #246

Open

darrenboyd opened this issue Dec 1, 2023 · 1 comment

darrenboyd commented Dec 1, 2023

Found some ineffective guard clauses that do a guard check, but don't return...

discordrb/lib/discordrb/data/overwrite.rb

Line 68 in 0f01116

false unless other.is_a? Discordrb::Overwrite

discordrb/lib/discordrb/permissions.rb

Line 139 in 0f01116

false unless other.is_a? Discordrb::Permissions

Member

Daniel-Worrall commented Dec 1, 2023

Nice catch
First introduced 9ba6e52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment