Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing core tests test_requirejs #20

Open
dmitriim opened this issue Aug 19, 2022 · 3 comments · May be fixed by #21
Open

Failing core tests test_requirejs #20

dmitriim opened this issue Aug 19, 2022 · 3 comments · May be fixed by #21

Comments

@dmitriim
Copy link

The plugin fails one of the core Moodle tests. Tested in Moodle 3.9. See below.

There was 1 failure:

1) core_requirejs_testcase::test_requirejs
Failed asserting that '/var/www/moodle39/filter/syntaxhighlighter/amd/build/hljs.js' contains ".min".

/var/www/moodle39/lib/tests/requirejs_test.php:91
/var/www/moodle39/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit "core_requirejs_testcase" lib/tests/requirejs_test.php

FAILURES!
Tests: 1, Assertions: 1998, Failures: 1.
@dmitriim dmitriim linked a pull request Aug 19, 2022 that will close this issue
Open
@dmitriim
Copy link
Author

Fix for that issues #21

@dmitriim
Copy link
Author

Hi @sharpchi !
Any chance you can have a look at this issue and related PR? Thanks!

@mazitov-az
Copy link

Hi @sharpchi !
We also have a similar problem.
We use Moodle 4.1
Предложенное решение кажется хорошим! #21
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue#20: apply grunt amd results catalyst/moodle-filter_syntaxhighlighter
2 participants
@dmitriim @mazitov-az