Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README is incorrect for creating container #92

Open
aferrebee opened this issue Nov 8, 2023 · 2 comments
Open

README is incorrect for creating container #92

aferrebee opened this issue Nov 8, 2023 · 2 comments

Comments

@aferrebee
Copy link

The README file say to run docker run -d --name=protonmail-bridge -v protonmail:/root -p 1025:25/tcp -p 1143:143/tcp --restart=unless-stopped shenxn/protonmail-bridge

but this causes the wrong port to be exposed for the contain. Since 1025 and 1143 are mapped to 25 and 143 with socat so the README commands should be
docker run -d --name=protonmail-bridge -v protonmail:/root -p 25:25/tcp -p 143:143/tcp --restart=unless-stopped shenxn/protonmail-bridge

@therealstein
Copy link

I see nothing incorrect or wrong. It’s totally your decision how to map the exposed ports.

@graememclaughlin
Copy link

I would note that there is a difference here on port selection. If I map to port 25 on the container (instead of the configured 1025), I am able to connect. Not so if I map 1025:1025. I'm guessing socat is fooling protonmail-bridge into accepting the connection from an "outside" machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants