-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Province of City is always wrong -- Only in belgium .. #25
Comments
Nevermind, only seems to be the case in Belgium so it seems. No idea why though. Guess it's kinda like our government. |
Update: in your file geoname2fips.py you write
But It's supposed to be VLAAMS BRABANT. However I cant seem to make it write a fips csv from it (absolutely clueless what parameters it is accepting) so I can't test if that fixed worked or not... Indeed, all the flemish cities are being marked as being in flemish brabant, fixing that to flanders would indeed fix it. Can anyone help? |
I found out the problem. Please take a look at following pull request: I now have all the provinces working instead of just the general region (which was wrong and fixed on a single province for all cities) |
this is fixed but I need to generate new csv, did you modified it by hand? |
I generated it with a bash script, I couldn't get the python module to work properly. I simply took a look of the geolite's extracted location file for the used BE provnames and at the fips 10-4 province id's and then generated the csv with all the correct ids for all BE cities, and replaced it with all the wrong be entries. I'll leave it to you to decide what to do in the python code... |
Dont know if I'm doing something wrong but everything is correct except the Province of the city. Is this an issue observed by others aswel?
The text was updated successfully, but these errors were encountered: