From 58b7898defae29a786b59e8fb8352e7edb54e151 Mon Sep 17 00:00:00 2001 From: Sergio Padrino Date: Mon, 12 Aug 2024 16:00:26 +0200 Subject: [PATCH 1/4] Enable custom integrations on beta --- app/src/lib/feature-flag.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/lib/feature-flag.ts b/app/src/lib/feature-flag.ts index 482edddf74e..9fc25996b20 100644 --- a/app/src/lib/feature-flag.ts +++ b/app/src/lib/feature-flag.ts @@ -99,4 +99,4 @@ export const enableLinkUnderlines = enableDiffCheckMarksAndLinkUnderlines export const enableExternalCredentialHelper = () => true export const enableCredentialHelperTrampoline = () => true -export const enableCustomIntegration = enableDevelopmentFeatures +export const enableCustomIntegration = enableBetaFeatures From f76050b865357b3530b70c47c8bb8162372b0567 Mon Sep 17 00:00:00 2001 From: Sergio Padrino Date: Mon, 12 Aug 2024 16:02:56 +0200 Subject: [PATCH 2/4] Bump changelog and version to v3.4.4-beta1 --- app/package.json | 2 +- changelog.json | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/package.json b/app/package.json index 0146efd3c73..609b965577a 100644 --- a/app/package.json +++ b/app/package.json @@ -3,7 +3,7 @@ "productName": "GitHub Desktop", "bundleID": "com.github.GitHubClient", "companyName": "GitHub, Inc.", - "version": "3.4.3", + "version": "3.4.4-beta1", "main": "./main.js", "repository": { "type": "git", diff --git a/changelog.json b/changelog.json index cdb34d92370..613142c24fe 100644 --- a/changelog.json +++ b/changelog.json @@ -1,5 +1,10 @@ { "releases": { + "3.4.4-beta1": [ + "[Fixed] Only ask for SSH credentials for the selected repository and only delete them after an authentication error - #19019", + "[Added] Add Cursor support on macOS - #17462. Thanks @bjorntechCarl!", + "[Added] Add JetBrains RustRover support - #18802. Thanks @Radd-Sma!" + ], "3.4.3": [ "[Added] Add Zed as an external editor option for Linux - #18962. Thanks @adil192!", "[Fixed] Allow pushing to gists - #19009", From 83dec9ec15b900ddf3e7b5b4fbb1195dac5fec3b Mon Sep 17 00:00:00 2001 From: Sergio Padrino Date: Mon, 12 Aug 2024 16:03:19 +0200 Subject: [PATCH 3/4] Fix order in changelog of fixed vs added --- changelog.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.json b/changelog.json index 613142c24fe..e9532bc283f 100644 --- a/changelog.json +++ b/changelog.json @@ -7,8 +7,8 @@ ], "3.4.3": [ "[Added] Add Zed as an external editor option for Linux - #18962. Thanks @adil192!", - "[Fixed] Allow pushing to gists - #19009", "[Added] Shift + F10 opens context menu's on macOS", + "[Fixed] Allow pushing to gists - #19009", "[Fixed] The copy button announces when clicked in VoiceOver.", "[Fixed] Context menu actions in the diff are accessible via keyboard - #18946", "[Fixed] Add/Remove Co-authors hint text is positioned correctly when scrolling through the changes list - #18929", From 4f78274902b00a5ee016b35ae50437737c8317c5 Mon Sep 17 00:00:00 2001 From: Sergio Padrino Date: Mon, 12 Aug 2024 18:05:38 +0200 Subject: [PATCH 4/4] Fix order of changelog :facepalm: --- changelog.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/changelog.json b/changelog.json index e9532bc283f..2be800c4f9e 100644 --- a/changelog.json +++ b/changelog.json @@ -1,9 +1,10 @@ { "releases": { "3.4.4-beta1": [ - "[Fixed] Only ask for SSH credentials for the selected repository and only delete them after an authentication error - #19019", + "[New] Add support for custom editors and shells - #18954", "[Added] Add Cursor support on macOS - #17462. Thanks @bjorntechCarl!", - "[Added] Add JetBrains RustRover support - #18802. Thanks @Radd-Sma!" + "[Added] Add JetBrains RustRover support - #18802. Thanks @Radd-Sma!", + "[Fixed] Only ask for SSH credentials for the selected repository and only delete them after an authentication error - #19019" ], "3.4.3": [ "[Added] Add Zed as an external editor option for Linux - #18962. Thanks @adil192!",