Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set_tasks_magnitude_and_phase modification #2

Open
NLopezRios opened this issue Dec 1, 2022 · 2 comments
Open

Set_tasks_magnitude_and_phase modification #2

NLopezRios opened this issue Dec 1, 2022 · 2 comments

Comments

@NLopezRios
Copy link

Would it be possible to modify the Set_tasks_magnitude_and_phase macro so that the phases of the Extra Tasks ("CPmode", "negCPMode" and "zeroPhase") can be adjusted by entering the project-specific CP phases extracted from the experimental data, or at least warn/prompt the user to do so?

@kylemgilbert
Copy link

In Set_tasks_magnitude_and_phase, the variable Phases refers to the list of phase offsets calculated through the VOP code for every channel. The CPmodePhases refers to the experimental CP mode phases (i.e., what you would set on the scanner for TrueForm mode. Is this already what you want? Perhaps we just need better commenting in the code?

@NLopezRios
Copy link
Author

Yes, but it looks like I didn't use the most recent versions, because I don't see CPmodePhases in them. Good to know it's done. I downloaded them on Nov 15, when I started working on the new VOPs and I heard that you had already modified them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants