Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to preventDefault inside passive event listener due to target being treated as passive. #1890

Open
michaelrampl opened this issue Apr 21, 2022 · 2 comments

Comments

@michaelrampl
Copy link

michaelrampl commented Apr 21, 2022

Simple steps like

{
        id: '...',
        attachTo: {
          element: '...',
          on: ''
        },
        classes: "...",
      }

trigger the following error

[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. 
See https://www.chromestatus.com/feature/5093566007214080

on mobile systems. As a result, mobile users on both android and ios are not being able to scroll the view (where shepherd is attoched to) anymore.

I'm using angular-shepherd version 12.0.0

Might be related to #1717

@RobbieTheWagner
Copy link
Member

@michaelrampl I am able to scroll the page just fine on iOS on https://shepherdjs.dev/

The part that is not scrollable is the highlighted target. Do you have a target that takes up most of the screen and breaks scrolling or something? We could perhaps just remove the touch scroll blocking. I do not recall what we needed it for.

@michaelrampl
Copy link
Author

I face the issue 2 times within my application. Both times, the highlighted area stretches widely among the screen thus needs most of the space and breaks scrolling exactly as you mentioned. Additionally, both times I hide the message box "display: none" Because the user wouldn't see what to do otherwise. The workaround from #1717 also works for me thus I think we face the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants