[BUG] Throw_range only goes halfway #3487
Labels
Bug
Something isn't working
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This fix removes a second increment to the dist_travelled variable. This line appears to have caused the throwing range of items to be halved, effectively. This fix should make it so that thrown objects go as far as they are intended to. ## Why It's Good For The Game Resolves the issue linked here: #3487 ## Changelog :cl: fix: fixed halved throw range /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
zimon9
added a commit
to zimon9/Shiptest-PR-testing
that referenced
this issue
Oct 29, 2024
…3522) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This fix removes a second increment to the dist_travelled variable. This line appears to have caused the throwing range of items to be halved, effectively. This fix should make it so that thrown objects go as far as they are intended to. ## Why It's Good For The Game Resolves the issue linked here: shiptest-ss13#3487 ## Changelog :cl: fix: fixed halved throw range /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction:
On items that have throw_range (hand grenades, knives, spears), they'll have a throw range of, say, 6 or 8 or something. In practice, it'll be more like 3 and 4.
This is probably not intended and I'm not really sure whats wrong
The text was updated successfully, but these errors were encountered: