Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple errors in flaky test create_and_destroy #3528

Open
github-actions bot opened this issue Oct 10, 2024 · 4 comments
Open

Multiple errors in flaky test create_and_destroy #3528

github-actions bot opened this issue Oct 10, 2024 · 4 comments
Labels
🤖 Flaky Test Report

Comments

@github-actions
Copy link
Contributor

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

create_and_destroy: [2024-10-10 23:41:21] Runtime in code/datums/elements/_element.dm,63: Incompatible the sarathi right leg assigned to a /obj/item/bodypart/leg/right/lizard/digitigrade! args: [{"sarathi right leg":null,"icons/mob/species/lizard/bodyparts.dmi":null,"":null,"_color":"#009696"}]
proc name:  AddElement (/datum/proc/_AddElement)
src: the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade)
src.loc: the floor (3,44,2) (/turf/open/floor/plasteel)
call stack:
the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade):  AddElement(/list (/list))
/datum/component/forensics (/datum/component/forensics): check blood()
/datum/component/forensics (/datum/component/forensics): Initialize(null, null, /list (/list), null)
/datum/component/forensics (/datum/component/forensics): New(/list (/list))
the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade):  AddComponent(/list (/list))
the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade): add blood DNA(/list (/list))
the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter): fly towards(the edge (3,46,2) (/turf/closed/indestructible/edge), 3)
world: ImmediateInvokeAsync(the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter), "fly_towards", the edge (3,46,2) (/turf/closed/indestructible/edge), 3) at code/datums/elements/_element.dm:63
create_and_destroy: [2024-10-10 23:41:21] Runtime in code/datums/elements/_element.dm,63: Incompatible the sarathi right leg assigned to a /obj/item/bodypart/leg/right/lizard/digitigrade! args: [{"sarathi right leg":null,"icons/mob/species/lizard/bodyparts.dmi":null,"":null,"_color":"#009696"}]
proc name:  AddElement (/datum/proc/_AddElement)
src: the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade)
src.loc: the floor (3,44,2) (/turf/open/floor/plasteel)
call stack:
the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade):  AddElement(/list (/list))
/datum/component/forensics (/datum/component/forensics): check blood()
/datum/component/forensics (/datum/component/forensics): RegisterWithParent()
/datum/component/forensics (/datum/component/forensics):  JoinParent(the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade))
/datum/component/forensics (/datum/component/forensics): New(/list (/list))
the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade):  AddComponent(/list (/list))
the sarathi right leg (/obj/item/bodypart/leg/right/lizard/digitigrade): add blood DNA(/list (/list))
the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter): fly towards(the edge (3,46,2) (/turf/closed/indestructible/edge), 3)
world: ImmediateInvokeAsync(the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter), "fly_towards", the edge (3,46,2) (/turf/closed/indestructible/edge), 3) at code/datums/elements/_element.dm:63
create_and_destroy: [2024-10-10 23:41:21] Runtime in code/datums/elements/_element.dm,63: Incompatible Shatalg-Shah's head assigned to a /obj/item/bodypart/head/lizard! args: [{"Shatalg-Shah's head":null,"icons/mob/species/lizard/bodyparts.dmi":null,"":null,"_color":"#009696"}]
proc name:  AddElement (/datum/proc/_AddElement)
src: Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard)
src.loc: the floor (4,43,2) (/turf/open/floor/plasteel)
call stack:
Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard):  AddElement(/list (/list))
/datum/component/forensics (/datum/component/forensics): check blood()
/datum/component/forensics (/datum/component/forensics): Initialize(null, null, /list (/list), null)
/datum/component/forensics (/datum/component/forensics): New(/list (/list))
Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard):  AddComponent(/list (/list))
Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard): add blood DNA(/list (/list))
the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter): fly towards(the floor (5,43,2) (/turf/open/floor/plasteel), 2)
world: ImmediateInvokeAsync(the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter), "fly_towards", the floor (5,43,2) (/turf/open/floor/plasteel), 2) at code/datums/elements/_element.dm:63
create_and_destroy: [2024-10-10 23:41:21] Runtime in code/datums/elements/_element.dm,63: Incompatible Shatalg-Shah's head assigned to a /obj/item/bodypart/head/lizard! args: [{"Shatalg-Shah's head":null,"icons/mob/species/lizard/bodyparts.dmi":null,"":null,"_color":"#009696"}]
proc name:  AddElement (/datum/proc/_AddElement)
src: Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard)
src.loc: the floor (4,43,2) (/turf/open/floor/plasteel)
call stack:
Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard):  AddElement(/list (/list))
/datum/component/forensics (/datum/component/forensics): check blood()
/datum/component/forensics (/datum/component/forensics): RegisterWithParent()
/datum/component/forensics (/datum/component/forensics):  JoinParent(Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard))
/datum/component/forensics (/datum/component/forensics): New(/list (/list))
Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard):  AddComponent(/list (/list))
Shatalg-Shah\'s head (/obj/item/bodypart/head/lizard): add blood DNA(/list (/list))
the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter): fly towards(the floor (5,43,2) (/turf/open/floor/plasteel), 2)
world: ImmediateInvokeAsync(the blood splatter (/obj/effect/decal/cleanable/blood/hitsplatter), "fly_towards", the floor (5,43,2) (/turf/open/floor/plasteel), 2) at code/datums/elements/_element.dm:63
@FalloutFalcon
Copy link
Member

im really not sure how this can happen in a create and destroy test. Intresting to say the least.

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 1, 2024

Flaky tests were detected again in this test run.
Failures:

create_and_destroy: [2024-11-01 18:16:06] Runtime in code/datums/components/_component.dm,408: Attempted to add a new component of type [/datum/component/forensics] to a qdeleting parent of type [/obj/item/toy/eightball]!
proc name:  AddComponent (/datum/proc/_AddComponent)
src: the magic eightball (/obj/item/toy/eightball)
src.loc: the explorer bag (/obj/item/storage/backpack/explorer)
call stack:
the magic eightball (/obj/item/toy/eightball):  AddComponent(/list (/list))
the magic eightball (/obj/item/toy/eightball): add fingerprint(Steven Bash (/mob/living/carbon/human), 1)
Miner (Legion) (/datum/outfit/generic/miner): apply fingerprints(Steven Bash (/mob/living/carbon/human))
Miner (Legion) (/datum/outfit/generic/miner): equip(Steven Bash (/mob/living/carbon/human), 0, null)
Steven Bash (/mob/living/carbon/human): equipOutfit(Miner (Legion) (/datum/outfit/generic/miner), 0, null)
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): equip(Steven Bash (/mob/living/carbon/human))
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): create(null, null)
world: ImmediateInvokeAsync(Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested), "create")
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): Initialize(0)
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): Initialize(0)
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): Initialize(0)
Atoms (/datum/controller/subsystem/atoms): InitAtom(Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested), /list (/list))
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): New(0)
/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run()
RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list))
RunUnitTests()
/datum/callback (/datum/callback): InvokeAsync() at code/datums/components/_component.dm:408
create_and_destroy: [2024-11-01 18:16:06] Runtime in code/modules/detectivework/detective_work.dm,35: Cannot execute null.add fingerprint().
proc name: add fingerprint (/atom/proc/add_fingerprint)
src: the magic eightball (/obj/item/toy/eightball)
src.loc: the explorer bag (/obj/item/storage/backpack/explorer)
call stack:
the magic eightball (/obj/item/toy/eightball): add fingerprint(Steven Bash (/mob/living/carbon/human), 1)
Miner (Legion) (/datum/outfit/generic/miner): apply fingerprints(Steven Bash (/mob/living/carbon/human))
Miner (Legion) (/datum/outfit/generic/miner): equip(Steven Bash (/mob/living/carbon/human), 0, null)
Steven Bash (/mob/living/carbon/human): equipOutfit(Miner (Legion) (/datum/outfit/generic/miner), 0, null)
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): equip(Steven Bash (/mob/living/carbon/human))
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): create(null, null)
world: ImmediateInvokeAsync(Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested), "create")
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): Initialize(0)
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): Initialize(0)
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): Initialize(0)
Atoms (/datum/controller/subsystem/atoms): InitAtom(Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested), /list (/list))
Mob Spawner (/obj/effect/mob_spawn/human/corpse/damaged/legioninfested): New(0)
/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy): Run()
RunUnitTest(/datum/unit_test/create_and_de... (/datum/unit_test/create_and_destroy), /list (/list))
RunUnitTests()
/datum/callback (/datum/callback): InvokeAsync() at code/modules/detectivework/detective_work.dm:35
create_and_destroy: /obj/item/storage/backpack/explorer hard deleted 1 times out of a total del count of 6 at code/modules/unit_tests/create_and_destroy.dm:195
create_and_destroy: /obj/item/toy/eightball hard deleted 1 times out of a total del count of 3 at code/modules/unit_tests/create_and_destroy.dm:195

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 4, 2024

Flaky tests were detected again in this test run.

@github-actions GitHub Actions
Copy link
Contributor Author

Flaky tests were detected again in this test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 Flaky Test Report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FalloutFalcon