Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shp as a kubectl plugin with Krew #102

Open
adambkaplan opened this issue Mar 9, 2022 · 4 comments
Open

Use shp as a kubectl plugin with Krew #102

adambkaplan opened this issue Mar 9, 2022 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@adambkaplan
Copy link
Member

Feature Request

Krew provides a management system for Kubernetes plugins.
Kubernetes plugins have a fairly simple API contract:

  • Binary must be named kubectl-xxx, where xxx is the plugin name.
  • Binary is placed in a specified path known to kubectl

This would allow the shp commands to be invoked indirectly with kubectl:

$ kubectl shp build run ...

There are a few advantages to creating a kubectl plugin:

  • Shipwright's binary can inherit context/configuration from kubectl.
  • Package managers like krew make it easier for developers to adopt Shipwright.

See the developer documentation for best practices on how we could distribute shp as a plugin.

/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2022
@SaschaSchwarze0
Copy link
Member

From grooming: nothing that we consider to be done soon.

@adambkaplan adambkaplan added this to the Backlog milestone Mar 23, 2022
@otaviof
Copy link
Member

otaviof commented Mar 23, 2022

We should split this into tasks:

  • Make sure we publish kubectl-shp for the same platforms supported;
  • Create and submit a Krew Manifest;

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Apr 14, 2023

I'm interested in this,Can i work for it?

/cc @adambkaplan @SaschaSchwarze0 @otaviof

@otaviof
Copy link
Member

otaviof commented Apr 14, 2023

I'm interested in this,Can i work for it?

Sure, please go head! 🙏 Let me know anything I may help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

5 participants