Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The prefix name of release archive files shoule be shp? #179

Open
liangyuanpeng opened this issue Apr 14, 2023 · 1 comment · May be fixed by #180
Open

The prefix name of release archive files shoule be shp? #179

liangyuanpeng opened this issue Apr 14, 2023 · 1 comment · May be fixed by #180
Assignees
@liangyuanpeng
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Apr 14, 2023 •
edited
Loading

The prefix name of release archive files is cli today, and i believe that it should be shp.

Prefix with kubectl-shp if we release a kubectl plugin of shp.

Other project cli name for release :

Command of tkn:
https://github.com/tektoncd/cli/releases/tag/v0.30.1

project name is cli and release file name with prefix tkn

command of gh:
https://github.com/cli/cli/releases/tag/v2.27.0

Project name is cli and release file name with prefix gh

Remind me if i missed something,Thanks.
@otaviof
Copy link
Member

otaviof commented Apr 14, 2023

@liangyuanpeng I think you're correct, the artifact should have the shp as it's prefix.

@otaviof otaviof added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 14, 2023
@liangyuanpeng liangyuanpeng linked a pull request Apr 14, 2023 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liangyuanpeng liangyuanpeng

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add kubectl shp for release liangyuanpeng/shipwright-cli
2 participants
@otaviof @liangyuanpeng