Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for parameters, part 1 #224

Closed
1 task done
SaschaSchwarze0 opened this issue Feb 26, 2024 · 2 comments · Fixed by #274
Closed
1 task done

[FEATURE] Support for parameters, part 1 #224

SaschaSchwarze0 opened this issue Feb 26, 2024 · 2 comments · Fixed by #274
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Feb 26, 2024

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

Build strategies support custom parameters for a long time already. In the meantime = in the Beta API, even the Dockerfile name has become a parameter.

We should finally add support for parameters in the CLI.

As a first step, let's start with single-values.

Describe the solution that you would like.

Here is my suggestion:

shp build create <NAME> --param-value <PARAMETER_NAME>:<PARAMETER_VALUE>

shp build run <NAME> --param-value <PARAMETER_NAME>:<PARAMETER_VALUE>

shp buildrun create <NAME> --param-value <PARAMETER_NAME>:<PARAMETER_VALUE>

NOTE: we do not have a shp build update command. We therefore do not need to think about how to remove a parameter.

TBD: Is the colon (:) a good separator, or should we use the equal sign (=) instead ?

Describe alternatives you have considered.

No response

Anything else?

Once this is done, we should open an issue with part 2 with array support.

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2024
@qu1queee qu1queee added this to the release-v0.13.0 milestone Mar 21, 2024
@qu1queee
Copy link
Contributor

From refinement, not a release blocker, as CLI will rely on v1alpha1 for v0.13.0. Moving out of the v0.13.0 milestone.

@qu1queee qu1queee removed this from the release-v0.13.0 milestone Mar 21, 2024
@apoorvajagtap
Copy link
Member

/assign @apoorvajagtap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants