Goreleaser package management #47

akram · 2021-09-28T15:39:02Z

Changes

Enables Goreleaser to allow pacjage releases.

Fixes #23

Submitter Checklist

Includes tests if functionality changed/was added
Includes docs if changes are user-facing
Set a kind label on this PR
Release notes block has been filled in, or marked NONE

Release Notes

Adds Goreleaser to allow package releases.

akram · 2021-09-29T08:25:06Z

@HeavyWombat do you have any experience with RPM/deb creations using nFPM => https://github.com/goreleaser/nfpm ?

@otaviof do you think that having also RPMs would be interesting for us? That would be for upstream only by the way.

akram · 2021-09-29T08:25:46Z

/assign @HeavyWombat

otaviof · 2021-09-29T09:45:05Z

@akram I'm okay if we look at more advanced packing options, like RPMs, as a next step. So, we can review this pull-request as it's and plan RPMs later on :-)

akram · 2021-09-29T10:57:13Z

Yes, that would be nice. Especially that nFPM seems to be a totally different product and I didn't see any integration with goreleaser.

gabemontero · 2021-10-05T15:53:02Z

/approve

@akram if you still want feedback from @HeavyWombat on his experiences re: #47 (comment), and if he does not have cycles to catch our tagging of him here, see about pinging him in the shipwright channel on k8s slack

fwiw I am fine merging this as an initial step as is, with follow ups with @HeavyWombat as well as what you and @otaviof already discussed

openshift-ci · 2021-10-05T15:53:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

HeavyWombat · 2021-10-06T13:25:36Z

@HeavyWombat do you have any experience with RPM/deb creations using nFPM => https://github.com/goreleaser/nfpm ?

@otaviof do you think that having also RPMs would be interesting for us? That would be for upstream only by the way.

I am sorry for the delayed response. Was booked with so many other things.

With regards to nFPM, I have no experience with this. So far, I only used GoReleaser for Homebrew Taps and Snap where only the raw binaries do the trick.

HeavyWombat

Nit: I would opt for removing the go mod tidy just to keep the hooks small and focused.

.goreleaser.yml

HeavyWombat

We just realized during our Shipwright community, we should also use this PR to include a release GitHub Action. One example would be: https://github.com/homeport/dyff/blob/main/.github/workflows/release.yml. This works for Homebrew and Snapcraft.

coreydaley · 2021-10-11T14:24:27Z

This pull request shows 19 extra commits, I think something went awry with your rebase ...

SaschaSchwarze0

Some other things beside the problem that somehow other commits landed in this PR.

.github/workflows/release.yml

adambkaplan · 2021-10-11T16:17:15Z

@akram it looks like a rebase broke the commit history here. Can you please rebase this branch so only the commits we're interested in are included?

…onfig

akram · 2021-10-11T20:15:48Z

@adambkaplan and @coreydaley indeed, I don't know what happened; my git client was updated and some default configuration changed. Now it is fixed; I synced my main branch and cherry-picked the right commits.

SaschaSchwarze0

Looks good to me. @adambkaplan may you check the secret references from Akram in the repository settings?

/assign adambkaplan

adambkaplan

Setting up credentials for Homebrew and Snap will require additional effort. Can this be scaled back so that we just upload cross-compiled binaries to Github?

adambkaplan · 2021-10-13T14:39:59Z

.github/workflows/release.yml

+          args: release --rm-dist
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          HOMEBREW_TAP_GITHUB_TOKEN: ${{ secrets.HOMEBREW_TAP_GITHUB_TOKEN }}


@akram is this something we need to add to the organization?

yes, that's it.

adambkaplan · 2021-10-13T14:40:32Z

.github/workflows/release.yml

+          sudo snap install snapcraft --classic
+          snapcraft login --with - <<<"${SNAP_TOKEN}"
+        env:
+          SNAP_TOKEN: ${{ secrets.SNAP_LOGIN }}


@akram looks like this also needs to be added to the organization (we should coordinate offline)

adambkaplan · 2021-10-25T20:17:46Z

/close

In favor of #61

openshift-ci · 2021-10-25T20:17:48Z

@adambkaplan: Closed this PR.

In response to this:

/close

In favor of #61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 28, 2021

openshift-ci bot requested review from imjasonh and sbose78 September 28, 2021 15:39

akram changed the title ~~WIP: Goreleaser package management~~ Goreleaser package management Sep 29, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021

openshift-ci bot assigned HeavyWombat Sep 29, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2021

adambkaplan added this to the release-v0.6.0 milestone Oct 6, 2021

HeavyWombat requested changes Oct 6, 2021

View reviewed changes

.goreleaser.yml Outdated Show resolved Hide resolved

HeavyWombat added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 11, 2021

SaschaSchwarze0 mentioned this pull request Oct 11, 2021

October 11, 2021 Community Meeting shipwright-io/community#33

Closed

HeavyWombat requested changes Oct 11, 2021

View reviewed changes

SaschaSchwarze0 requested changes Oct 11, 2021

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

akram added 2 commits October 11, 2021 20:08

Goreleaser package management

2e1294e

Add GitHub Actions release target, remove go mod tidy in goreleaser c…

20e7f6e

…onfig

akram force-pushed the goreleaser branch from 897ac39 to 20e7f6e Compare October 11, 2021 20:12

SaschaSchwarze0 approved these changes Oct 12, 2021

View reviewed changes

openshift-ci bot assigned adambkaplan Oct 12, 2021

adambkaplan requested changes Oct 13, 2021

View reviewed changes

imjasonh mentioned this pull request Oct 18, 2021

October 18, 2021 Community Meeting shipwright-io/community#38

Closed

openshift-ci bot closed this Oct 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Goreleaser package management #47

Goreleaser package management #47

akram commented Sep 28, 2021 •

edited by HeavyWombat

Loading

akram commented Sep 29, 2021

akram commented Sep 29, 2021

otaviof commented Sep 29, 2021 •

edited

Loading

akram commented Sep 29, 2021

gabemontero commented Oct 5, 2021

openshift-ci bot commented Oct 5, 2021

HeavyWombat commented Oct 6, 2021

HeavyWombat left a comment

HeavyWombat left a comment

coreydaley commented Oct 11, 2021 •

edited

Loading

SaschaSchwarze0 left a comment

adambkaplan commented Oct 11, 2021

akram commented Oct 11, 2021 •

edited

Loading

SaschaSchwarze0 left a comment

adambkaplan left a comment

adambkaplan Oct 13, 2021

akram Oct 14, 2021

adambkaplan Oct 13, 2021

akram Oct 14, 2021

adambkaplan commented Oct 25, 2021

openshift-ci bot commented Oct 25, 2021

Goreleaser package management #47

Goreleaser package management #47

Conversation

akram commented Sep 28, 2021 • edited by HeavyWombat Loading

Changes

Submitter Checklist

Release Notes

akram commented Sep 29, 2021

akram commented Sep 29, 2021

otaviof commented Sep 29, 2021 • edited Loading

akram commented Sep 29, 2021

gabemontero commented Oct 5, 2021

openshift-ci bot commented Oct 5, 2021

HeavyWombat commented Oct 6, 2021

HeavyWombat left a comment

Choose a reason for hiding this comment

HeavyWombat left a comment

Choose a reason for hiding this comment

coreydaley commented Oct 11, 2021 • edited Loading

SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

adambkaplan commented Oct 11, 2021

akram commented Oct 11, 2021 • edited Loading

SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

adambkaplan left a comment

Choose a reason for hiding this comment

adambkaplan Oct 13, 2021

Choose a reason for hiding this comment

akram Oct 14, 2021

Choose a reason for hiding this comment

adambkaplan Oct 13, 2021

Choose a reason for hiding this comment

akram Oct 14, 2021

Choose a reason for hiding this comment

adambkaplan commented Oct 25, 2021

openshift-ci bot commented Oct 25, 2021

akram commented Sep 28, 2021 •

edited by HeavyWombat

Loading

otaviof commented Sep 29, 2021 •

edited

Loading

coreydaley commented Oct 11, 2021 •

edited

Loading

akram commented Oct 11, 2021 •

edited

Loading