Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong temperature handling in fluid products #306

Open
kubiix opened this issue Sep 29, 2024 · 0 comments
Open

Wrong temperature handling in fluid products #306

kubiix opened this issue Sep 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kubiix
Copy link

kubiix commented Sep 29, 2024

I believe that produced fluilds from recipes are handled incorrect is some cases.

This is observalbe for example in combination of pyMods and WaterWell mod
https://mods.factorio.com/mod/WaterWell

This mod provides New recipe water-well-flow with water as product with undefined temperature
{ type = "recipe", name = "water-well-flow", enabled = true, hidden = true, energy_required = 1, category = "water-well-production", ingredients = { }, results= { {type="fluid", name="water", amount=2000}, }, }

In this case temperature should be taken from fluid prototype of water - default_temperature = 15

{ type = "fluid", name = "water", default_temperature = 15, max_temperature = 100, heat_capacity = "0.2KJ", base_color = {r=0, g=0.34, b=0.6}, flow_color = {r=0.7, g=0.7, b=0.7}, icon = "__base__/graphics/icons/fluid/water.png", icon_size = 64, icon_mipmaps = 4, order = "a[fluid]-a[water]" }

Actually when modeling Electricity generation using boiler, Water well flow recipe is available with 100°C temperature

obrazek

If I set the correct temperature to the recipe product (editing the mod files), Water well flow recipe is available with 15°C temperature

obrazek

Think this behavior is not isolated only to water, but other fluids too, but in ths case the temperature affects calculations of boilers count, since boiling warmer water on input is more effective.

Also the dialog acts weird. Accepted fluid variant is not a "tab" or filter to display only production recipes with matching temperature, but all (for example Cooling water produces 100°C water). The same is fo clicking on See full list button.
Mor user friendly behavior should be

  • clicking on the temperature variant buton to set it to machine as now, but don't hide the dialog and instead of it filter the recipes
  • clicking on the See full list button then should list oll recipes for selected temprature.
  • filtering in full list would also prevent to multiselect recipes with various temperatures with Ctrl+click (which makes unsolvable model)
@kubiix kubiix added the bug Something isn't working label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant