Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test #18

Open
shuhei opened this issue Jan 27, 2018 · 1 comment
Open

Fix unit test #18

shuhei opened this issue Jan 27, 2018 · 1 comment

Comments

@shuhei
Copy link
Owner

shuhei commented Jan 27, 2018

Currently, the unit test is broken because of onclick="${() => alert('hello')}".

  • bel@4 renders it as onclick="() => alert(\'hello\')"
  • pelo just removes it to match the result of bel@4 for onclick=${() => alert('hello')}
@shuhei
Copy link
Owner Author

shuhei commented Jan 27, 2018

To be consistent with bel@4, we can render the event handler when a function is quoted with "" and remove it when it's not quoted. But I need more research on bel's behavior to figure out whether it's intentional or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant