Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carbon metrics to get dashboard support #93

Merged
merged 25 commits into from
Jun 4, 2020

Conversation

sahandilshan
Copy link
Contributor

@sahandilshan sahandilshan commented Apr 15, 2020

Purpose

$subject
fix #87

Security checks

Related PRs

wso2/carbon-analytics#1849

MetricsDataHolder.getInstance().getMetricManagementService().isEnabled()) {
try {
if (MetricsDataHolder.getInstance().getMetricManagementService().isReporterRunning(
"prometheus")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make this a constant? Maybe it should be a constant in the carbon metrics package.

Copy link
Contributor Author

@sahandilshan sahandilshan Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in 85ee5fb, There's no constant available in the carbon metrics, Hence introduce as a new constant.

fileCopyMetrics = new FileCopyMetrics(siddhiAppName);
}
} catch (IllegalArgumentException e) {
log.debug("Prometheus reporter is not running. Hence file metrics will not be initialise in "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be rephrased as "will not be initialized"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in 85ee5fb

@ramindu90 ramindu90 merged commit 472476e into siddhi-io:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request support for monitor the extenstion
2 participants