-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add carbon metrics to get dashboard support #93
Conversation
…into develop � Conflicts: � component/src/main/java/io/siddhi/extension/io/file/FileSource.java � component/src/main/java/io/siddhi/extension/io/file/util/FileSourceConfiguration.java � docs/api/latest.md � docs/index.md � pom.xml
MetricsDataHolder.getInstance().getMetricManagementService().isEnabled()) { | ||
try { | ||
if (MetricsDataHolder.getInstance().getMetricManagementService().isReporterRunning( | ||
"prometheus")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we make this a constant? Maybe it should be a constant in the carbon metrics package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed in 85ee5fb, There's no constant available in the carbon metrics, Hence introduce as a new constant.
fileCopyMetrics = new FileCopyMetrics(siddhiAppName); | ||
} | ||
} catch (IllegalArgumentException e) { | ||
log.debug("Prometheus reporter is not running. Hence file metrics will not be initialise in " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be rephrased as "will not be initialized"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed in 85ee5fb
Purpose
$subject
fix #87
Security checks
Related PRs
wso2/carbon-analytics#1849