Test forking of the goerli network

[valiafetisov]

Goal

Simulations work on goerli

Context

In order to work with the new spell on goerli, we should validate that it works if our setup works on goerli.

Tasks

• Test collateral simulation script on goerli
• Document any problems here, propose solutions
• Fix, if required

[valiafetisov]

Currently, simulation script "Simulate collateral auction per collateral type" fails with Error: No contract address found for "CDP_REGISTRY". The frontend started without any problems, as expected

Actual error thrown (after adding additional logging) is:

No contract address found for "CDP_REGISTRY" Error: call revert exception; VM Exception while processing transaction: reverted with reason string "dss-chain-log/invalid-key" [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="getAddress(bytes32)", data="0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000196473732d636861696e2d6c6f672f696e76616c69642d6b657900000000000000", errorArgs=["dss-chain-log/invalid-key"], errorName="Error", errorSignature="Error(string)", reason="dss-chain-log/invalid-key", code=CALL_EXCEPTION, version=abi/5.6.4)

[valiafetisov]

It turns out chainlog on goerli doesn't have CDP_REGISTRY contract for whatever reason. Not sure if it's deployed whatsoever? Next actions:

• Find if it's deployed, but wasn't added to the chainlog
• Check if we can remove this dependency to create vaults

[valiafetisov]

CDP_REGISTRY address on the mainnet: https://etherscan.io/address/0xBe0274664Ca7A68d6b5dF826FB3CcB7c620bADF3

[KirillDogadin-std]

Cdp registry on goerli is 0x0636E6878703E30aB11Ba13A68C6124d9d252e6B

https://goerli.etherscan.io/address/0x0636E6878703E30aB11Ba13A68C6124d9d252e6B#code

https://github.com/makerdao/spells-goerli/blob/b97c41e09f5657cbf577605cceb45edaf6421911/archive/2022-03-04-Charter-Sneak/Goerli-DssSpell.sol

[KirillDogadin-std]

Does not seem like we can just easily remove this dependency:

• there's not only the cdp registry missing, but also the cropper contract infrastructure. so, for instance, we are not able to find the target contract to execute actions on because PROXY_ACTIONS_CROPPER is also missing from the chainlog.
• due to the above it seems to me like we would have to rewrite at least half the logic in order to make this work in both places (unless we hardcode the logic for goerli somehow).

Let me know if i should look further.

[valiafetisov]

Cdp registry on goerli is

Great. Have you found it just by searching in the spells-goerli repo?

PROXY_ACTIONS_CROPPER

This seems unrelated to the GNO onboarding, as this collateral doesn't seem to require a cropper.

By (temporary) hardcoding the CDP_REGISTRY address I was able to create a ETH-A vault on goerli in #556. Technically, CDP_REGISTRY should only be required for the proxied collaterals, so we might reimplement this dependency as a fallback, not main code