-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.3.0 displays no registered accounts #59
Comments
Hi @Lycowolf , can you please provide the plugin console output (extensions -> gear-icon -> debug addon -> inspect). This should not contain any personal data, but better redact the login-url part. Just out of curiosity: Did you update the browser part and the host part in a lockstep? This should ideally not be needed (as we have no breaking change between the browser and the host), but maybe we have overlooked something. |
Console output (I clicked "reload" after the "Background event page..." message):
I am confused: the log looks completely OK? I first upgraded the addon, when it didn't work, I remembered I should upgrade the host part too and did it. I restarted the browser after that (several times, in fact). Downgrading the addon to 1.2.0 immediately fixed the issue (I didn't have to downgrade the host part). Just to be extra clear, with 1.3.0, the addon button doesn't react to left click at all, it isn't just an issue of tooltip or picture not updating. |
@Lycowolf Thanks for providing the log. I debugged it and found that the extension hangs if the user does not have a profile picture. Working on a fix. Once fixed, I'll cut a 1.3.1 release. |
In case the user does not have a profile picture, a fallback icon is used. This icon was not included in the firefox deployment, hence the loading of that failed and rejecting the promise (waiting for the icon to be come available). Closes: #59 Signed-off-by: Felix Moessbauer <[email protected]>
In case the user does not have a profile picture, a fallback icon is used. This icon was not included in the firefox deployment, hence the loading of that failed and rejecting the promise (waiting for the icon to be come available). Closes: #59 Signed-off-by: Felix Moessbauer <[email protected]>
In case the user does not have a profile picture, a fallback icon is used. This icon was not included in the firefox deployment, hence the loading of that failed and rejecting the promise (waiting for the icon to be come available). Closes: #59 Fixes: abbe285 ("feat: indicate broker online state in UI") Signed-off-by: Felix Moessbauer <[email protected]>
In case the user does not have a profile picture, a fallback icon is used. This icon was not included in the firefox deployment, hence the loading of that failed and rejecting the promise (waiting for the icon to be come available). Closes: #59 Fixes: abbe285 ("feat: indicate broker online state in UI") Signed-off-by: Felix Moessbauer <[email protected]>
Platform: Ubuntu 22.04 LTS, Plasma desktop, Firefox 134.0 (from the mozilla repo).
I upgraded to 1.3.0 and am unable to log in using Entra SSO. The extension icon tooltip says "EntraID SSO disabled (no accounts registered)". I can acquire the cookie manually without any problem (I have to redact most data as this is my work PC, but it looked OK to me):
Logging in using Edge works too.
I run
make local-install-firefox
using thev1.3.0
git tag.Downgrading to 1.2.0 works.
I would like to try and
git-bisect
this issue, but I am not sure if I'll find the time.The text was updated successfully, but these errors were encountered: