Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.0 displays no registered accounts #59

Open
Lycowolf opened this issue Jan 14, 2025 · 3 comments · May be fixed by #60
Open

v1.3.0 displays no registered accounts #59

Lycowolf opened this issue Jan 14, 2025 · 3 comments · May be fixed by #60

Comments

@Lycowolf
Copy link

Platform: Ubuntu 22.04 LTS, Plasma desktop, Firefox 134.0 (from the mozilla repo).

I upgraded to 1.3.0 and am unable to log in using Entra SSO. The extension icon tooltip says "EntraID SSO disabled (no accounts registered)". I can acquire the cookie manually without any problem (I have to redact most data as this is my work PC, but it looked OK to me):

~$ ~/.mozilla/linux-entra-sso.py --interactive -a0 acquirePrtSsoCookie
{
  "account": {
    "clientInfo": "...",
    "environment": "login.windows.net",
    "givenName": "...",
    "homeAccountId": "...",
    "localAccountId": "...",
    "name": "...",
    "passwordExpiry": 0,
    "realm": "...",
    "username": "..."
  },
  "cookieContent": "...",
  "cookieName": "x-ms-RefreshTokenCredential",
  "telemetry": {
    "os_version": "Ubuntu 22.04.5 LTS",
    "broker_version": "2.0.1",
    "dbus_method_name": "acquirePrtSsoCookie"
  }
}

Logging in using Edge works too.

I run make local-install-firefox using the v1.3.0 git tag.

Downgrading to 1.2.0 works.

I would like to try and git-bisect this issue, but I am not sure if I'll find the time.

@fmoessbauer
Copy link
Member

Hi @Lycowolf , can you please provide the plugin console output (extensions -> gear-icon -> debug addon -> inspect). This should not contain any personal data, but better redact the login-url part.

Just out of curiosity: Did you update the browser part and the host part in a lockstep? This should ideally not be needed (as we have no breaking change between the browser and the host), but maybe we have overlooked something.

@Lycowolf
Copy link
Author

Lycowolf commented Jan 14, 2025

Console output (I clicked "reload" after the "Background event page..." message):

[Linux Entra SSO] start linux-entra-sso [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] linux-entra-sso already initialized [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] connection to broker restored [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] loading accounts [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] active account: ...@... [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] API token acquired [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] Warning: Could not get profile picture. [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
Background event page was not terminated on idle because a DevTools toolbox is attached to the extension. [_generated_background_page.html](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/_generated_background_page.html)
[Linux Entra SSO] start linux-entra-sso [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] connection to broker restored [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] loading accounts [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] active account: ...@... [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
[Linux Entra SSO] API token acquired [background.js:28:13](moz-extension://abf2f1da-3040-453f-9b50-b1ef9b738157/background.js)
XHRGET
https://graph.microsoft.com/v1.0/me/photos/48x48/$value
[HTTP/2 404  88ms]

[Linux Entra SSO] Warning: Could not get profile picture.

I am confused: the log looks completely OK?

I first upgraded the addon, when it didn't work, I remembered I should upgrade the host part too and did it. I restarted the browser after that (several times, in fact). Downgrading the addon to 1.2.0 immediately fixed the issue (I didn't have to downgrade the host part).

Just to be extra clear, with 1.3.0, the addon button doesn't react to left click at all, it isn't just an issue of tooltip or picture not updating.

@fmoessbauer
Copy link
Member

@Lycowolf Thanks for providing the log. I debugged it and found that the extension hangs if the user does not have a profile picture. Working on a fix. Once fixed, I'll cut a 1.3.1 release.

fmoessbauer added a commit that referenced this issue Jan 14, 2025
In case the user does not have a profile picture, a fallback icon is
used. This icon was not included in the firefox deployment, hence the
loading of that failed and rejecting the promise (waiting for the icon
to be come available).

Closes: #59
Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer added a commit that referenced this issue Jan 14, 2025
In case the user does not have a profile picture, a fallback icon is
used. This icon was not included in the firefox deployment, hence the
loading of that failed and rejecting the promise (waiting for the icon
to be come available).

Closes: #59
Signed-off-by: Felix Moessbauer <[email protected]>
@fmoessbauer fmoessbauer linked a pull request Jan 14, 2025 that will close this issue
fmoessbauer added a commit that referenced this issue Jan 14, 2025
In case the user does not have a profile picture, a fallback icon is
used. This icon was not included in the firefox deployment, hence the
loading of that failed and rejecting the promise (waiting for the icon
to be come available).

Closes: #59
Fixes: abbe285 ("feat: indicate broker online state in UI")
Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer added a commit that referenced this issue Jan 15, 2025
In case the user does not have a profile picture, a fallback icon is
used. This icon was not included in the firefox deployment, hence the
loading of that failed and rejecting the promise (waiting for the icon
to be come available).

Closes: #59
Fixes: abbe285 ("feat: indicate broker online state in UI")
Signed-off-by: Felix Moessbauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants