fix(firefox): include missing profile avatar #60
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lycowolf It would be great if you could give this a try. Once confirmed that this solves your problem, I'll cut the v1.3.1 release. |
|
@fmoessbauer I tested it using firefox-esr and it worked: I was able to login no problem. |
fmoessbauer
force-pushed
the
fm/fix-no-profile-picture
branch
from
7715afc to
889d2f1
Compare
|
@Lycowolf Thanks for the confirmation. |
jan-kiszka
reviewed
Jan 14, 2025
In case the user does not have a profile picture, a fallback icon is used. This icon was not included in the firefox deployment, hence the loading of that failed and rejecting the promise (waiting for the icon to be come available). Closes: #59 Fixes: abbe285 ("feat: indicate broker online state in UI") Signed-off-by: Felix Moessbauer <[email protected]>
The profile-outline icon was mentioned in both the firefox as well as the chrome input files. Move it to the common files. Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/fix-no-profile-picture
branch
from
889d2f1 to
7d4de49
Compare
jan-kiszka
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the user does not have a profile picture, a fallback icon is used. This icon was not included in the firefox deployment, hence the loading of that failed and rejecting the promise (waiting for the icon to be come available).
Closes: #59