Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make folder of JS part a submodule #20

Open
KOLANICH opened this issue Aug 5, 2015 · 8 comments
Open

Make folder of JS part a submodule #20

KOLANICH opened this issue Aug 5, 2015 · 8 comments
Labels
feature request Community reported issues which are more feature request than issue

Comments

@KOLANICH
Copy link
Contributor

KOLANICH commented Aug 5, 2015

Move folder with JS part (/deploy/[Notepad++ Directory]/plugins/jN) to separate repo
Make it a submodule
Merge with https://github.com/KOLANICH/jN-npp-scripts

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jan 4, 2017

@sieukrem

@sieukrem
Copy link
Owner

sieukrem commented Jan 4, 2017

Could you explain the advantage of submodule aproach!?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jan 4, 2017

Now you have a single repo for JS and C++ parts of plugin, but they are relatively standalone: most of users don't need the C++ part of your repo, but everybody needs the JS one, and the JS part is interacting with C++ through API and is not needed in order to build. The advantage of having separate repos for that is that they can be cloned separately, so you can place JS part repo into your npp "plugins/jN/" dir, upgrade with git pull and develop in place. To install it a user just needs to clone it there. Now a user have to clone the whole repo and extract JS part from there. Another solution is to clone my repo ;)

@KOLANICH
Copy link
Contributor Author

@sieukrem

@sieukrem
Copy link
Owner

:)
I would go this way. Can you make a suggestion for corresponding appveyor.yml packaging scripts and dll together from different repositories?

@KOLANICH
Copy link
Contributor Author

In fact I have never used appveyor, but I guess git submodules should do the work as long as you can trigger submodule update.

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jan 3, 2018

@sieukrem

@AakaFosfor
Copy link

Not a bad idea with the submodule. If you'll want to go for it, only adding an "install" phase as described in the doc should be enough. The rest of the page should not apply, I suppose, as the repo will probably not be a private one.

@sieukrem sieukrem added the feature request Community reported issues which are more feature request than issue label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Community reported issues which are more feature request than issue
Projects
None yet
Development

No branches or pull requests

3 participants