Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: book.with-summary is fighting with the drop-down menus #93

Closed
marc-portier opened this issue Aug 13, 2023 · 3 comments
Closed

bug: book.with-summary is fighting with the drop-down menus #93

marc-portier opened this issue Aug 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@marc-portier
Copy link
Contributor

as a side effect of looking to #73 I noticed that he drop down menus (on the left for font + background, on the right for sharing) do not work if the summary-side bar is active.

I see the style-effects are still correctly applied (the .open class is added to the correct div.dropdown) but somehow that does not make the menus actually pop up.

I assume (for now) there is a conflict between the book.with-summary leading to left: 0 applied on a higher level. Would need more investigation, but wanted to share already in case somebody has a quicker eye on this.
@marc-portier
Copy link
Contributor Author

never mind my earlier left:0 remark -- that just works nicely to show-hide the summary.

I just did a quick comparison with the original gitbook style on some other site...
and it looks like the div.body-inner is missing from our style

it seems to add the needed context to reset some positions:
image

@sighingnow
Copy link
Owner

I can reproduce.

sighingnow added a commit that referenced this issue Aug 14, 2023
@sighingnow
Fixes the drop-down issue on both desktop and mobile.
676cf70 
Follow-up work for 2075f8e.

Resolves #93.

Signed-off-by: Tao He <[email protected]>
@sighingnow
Copy link
Owner

Fixed by 2075f8e and 676cf70.

@sighingnow sighingnow added the bug Something isn't working label Aug 27, 2023
jzstraley added a commit to jzstraley/jzstraley.github.io that referenced this issue Apr 28, 2024
@jzstraley
Squashed commit of the following:
3b86a0b 
commit 6bb91fe
Author: Tao He <[email protected]>
Date:   Fri Feb 23 00:19:29 2024 +0800

    Add documentation for how to use collections

    Signed-off-by: Tao He <[email protected]>

commit 8c0c775
Merge: 703c478 7a8febd
Author: Tao He <[email protected]>
Date:   Fri Feb 23 00:11:46 2024 +0800

    Merge pull request sighingnow#117 from Happypig375/master

    Try to fix the expender such that only direct children are expanded

commit 7a8febd
Author: Hadrian Tang <[email protected]>
Date:   Fri Feb 16 17:29:03 2024 +0800

    Try to fix the expender such that only direct children are expanded

commit 703c478
Author: Tao He <[email protected]>
Date:   Fri Dec 22 01:41:12 2023 +0800

    Remove the unused chapter-fold, add expandable-chapter plugin.

    Resolves sighingnow#112.

    Signed-off-by: Tao He <[email protected]>

commit c00e400
Author: Tao He <[email protected]>
Date:   Tue Dec 12 22:07:08 2023 +0800

    Fixes the anchors for footnotes in markdown, resolves sighingnow#109

    Signed-off-by: Tao He <[email protected]>

commit d00c0ce
Author: Tao He <[email protected]>
Date:   Tue Dec 12 21:29:01 2023 +0800

    Remove the 'fork it now' link, fixes sighingnow#108.

    Signed-off-by: Tao He <[email protected]>

commit 3fcd783
Author: Tao He <[email protected]>
Date:   Sat Oct 14 16:00:07 2023 +0800

    Fixes the tips.

    Signed-off-by: Tao He <[email protected]>

commit 7131afc
Author: Tao He <[email protected]>
Date:   Sat Oct 14 15:55:30 2023 +0800

    Fixes the mathjax rendering and add an example.

    Resolves sighingnow#104.

    Signed-off-by: Tao He <[email protected]>

commit 190c11d
Author: Tao He <[email protected]>
Date:   Sat Oct 14 15:37:22 2023 +0800

    Fixes render of mermaid diagrams when switch pages.

    Resolves sighingnow#105.

    Signed-off-by: Tao He <[email protected]>

commit 53d7c22
Author: Tao He <[email protected]>
Date:   Fri Sep 1 00:11:25 2023 +0800

    Support mermaid.js for diagrams.

    Resolves sighingnow#99.

    Signed-off-by: Tao He <[email protected]>

commit ef0c8dd
Author: Tao He <[email protected]>
Date:   Fri Sep 1 00:10:09 2023 +0800

    Fixes the right-arrow for navigation-next on narrow screens.

    Signed-off-by: Tao He <[email protected]>

commit f789687
Author: Tao He <[email protected]>
Date:   Mon Aug 28 10:15:43 2023 +0800

    Fixes the behaviour when width is between 1024 and 1240

    Signed-off-by: Tao He <[email protected]>

commit 6f8edb8
Author: Tao He <[email protected]>
Date:   Sun Aug 27 15:50:48 2023 +0800

    Fixes scrolling to subtitles.

    Closes sighingnow#98.

    Signed-off-by: Tao He <[email protected]>

commit 64643ae
Merge: 676cf70 9516366
Author: Tao He <[email protected]>
Date:   Tue Aug 15 19:32:23 2023 +0800

    Merge pull request sighingnow#95 from marc-portier/feature/custom-local-css

    fixin' the fix

commit 9516366
Author: Marc Portier <[email protected]>
Date:   Tue Aug 15 13:19:56 2023 +0200

    css import must be at the start of the file to work

    so to get the order correct, we have to include the -local.css from the html directly

commit 676cf70
Author: Tao He <[email protected]>
Date:   Mon Aug 14 21:35:39 2023 +0800

    Fixes the drop-down issue on both desktop and mobile.

    Follow-up work for 2075f8e.

    Resolves sighingnow#93.

    Signed-off-by: Tao He <[email protected]>

commit 2075f8e
Author: Tao He <[email protected]>
Date:   Mon Aug 14 21:30:23 2023 +0800

    Fixes the drop-down issue when book summary is displayed.

    The original line is to fixes sighingnow#56, but actually this issue
    was fixed by e758bc8 (for sighingnow#70).

    Resolves sighingnow#93.

    Signed-off-by: Tao He <[email protected]>

commit fc15a08
Merge: 99db37d 4b183a5
Author: Tao He <[email protected]>
Date:   Sun Aug 13 16:49:22 2023 +0800

    Merge pull request sighingnow#92 from marc-portier/feature/custom-local-css

    introduce custom-local-css for easy extending in a remote-theme setting

commit 4b183a5
Author: Marc Portier <[email protected]>
Date:   Sun Aug 13 09:29:46 2023 +0200

    introduce custom-local-css for easy extending in a remote-theme setting

    closes sighingnow#91

commit 99db37d
Merge: 9bd8539 4befaf0
Author: Tao He <[email protected]>
Date:   Tue Aug 8 19:08:16 2023 +0800

    Merge pull request sighingnow#89 from marc-portier/feature/social-share-support

    Feature slightly enhanced social share support

commit 4befaf0
Author: Marc Portier <[email protected]>
Date:   Tue Aug 8 12:03:31 2023 +0200

    make the social sharing links dynamically reflect entries in the _config.yml

commit 9722d17
Author: Marc Portier <[email protected]>
Date:   Tue Aug 8 11:54:49 2023 +0200

    allow overriding the social-share link for all

    this allows injecting a dedicated target link for all the supported social-media platforms -- not only github and telemark

commit 9bd8539
Author: Tao He <[email protected]>
Date:   Sun Mar 19 16:11:08 2023 +0800

    Add disqus comment to this theme.

    Signed-off-by: Tao He <[email protected]>

commit 6006e3a
Author: Tao He <[email protected]>
Date:   Sun Mar 19 15:49:38 2023 +0800

    Add the copy-code-button plugin.

    Signed-off-by: Tao He <[email protected]>

commit c651192
Author: Tao He <[email protected]>
Date:   Sun Mar 19 15:39:53 2023 +0800

    Resolves sighingnow#69.

    Signed-off-by: Tao He <[email protected]>

commit 10ff410
Author: Tao He <[email protected]>
Date:   Sun Mar 19 14:50:41 2023 +0800

    Fixes sighingnow#70.

    Signed-off-by: Tao He <[email protected]>

commit 9af9559
Author: Tao He <[email protected]>
Date:   Sun Feb 19 13:22:51 2023 +0800

    Fixes the overflow of sharing buttons on mobile screens.

    Closes sighingnow#56.

    Signed-off-by: Tao He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marc-portier @sighingnow