Add a jemalloc feature #2195
Closed
Add a jemalloc feature #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…malloc � Conflicts: � Cargo.lock � beacon_node/http_metrics/Cargo.toml � beacon_node/network/src/attestation_service/tests/mod.rs
|
FYI, I figured out that we need to use the Reference: gnzlbg/jemallocator#115 |
|
I've set this as |
|
Closed in favour of #2222 to keep the PRs tidy. Free free to reopen if you like :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
A potential improvement RAM creep
Proposed Changes
Add a feature which will use
jemallocas the global allocator and enable somejemallocmetricsAdditional Info
After running for a day, with
jemallocinstead of the default system allocator, my node was using about 1GB less of RAM. I have only tested on linux x86_64, and haven't done any longer-term testing so it could still be creeping. But I think it's worth experimenting with because it seems to have a reputation for handling memory fragmentation well, and has some interesting configuration options