Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Allow muitple default owners to be specified #240

Open
loxygenK opened this issue Sep 19, 2023 · 1 comment
Open

[feature request] Allow muitple default owners to be specified #240

loxygenK opened this issue Sep 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@loxygenK
Copy link

loxygenK commented Sep 19, 2023

Thanks very much for this great tool!

Feature explanation

With the default owner feature1 we can omit the owner name, but currently only single default owner can be specified. If multiple default owners is allowed, it would be convenient for the user who often commits to the project with multiple owners (like personal and company projects).

# Proposal behavior of the feature

$ cd ~/.ghr/ghr.toml
[defaults]
owners = ["owner-1", "owner-2"]

$ ghr list
github.com:owner-1/foo
github.com:owner-2/foo
github.com:owner-2/bar

$ ghr path bar
~/.ghr/github.com/owner-2/bar

# There are two repositories with the name "foo" (owner-1's and owner-2's)
$ ghr path foo
 ERR The path is ambiguous. Please specify the owner name

Implementation/UX consideration

  • Configuration scheme can change, so there is an issue with backward compatibility.

Footnotes

  1. https://github.com/siketyan/ghr#cloning-a-repository

@siketyan siketyan self-assigned this Sep 19, 2023
@siketyan siketyan added the enhancement New feature or request label Sep 19, 2023
@siketyan siketyan moved this from Planning to Todo in Feature Roadmap of ghr Sep 19, 2023
@siketyan
Copy link
Owner

siketyan commented Sep 19, 2023

We are going to add search_path configuration, superseding the defaults. ghr will try to find repos for each owners in the configured order

In addition, defaults will be deprecated and will be removed in the next major (0.x) release.

@siketyan siketyan added this to the v0.4 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants