Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activity and history dialogs need a close button #1330

Closed
hahn-kev opened this issue Dec 20, 2024 · 0 comments · Fixed by #1376
Closed

activity and history dialogs need a close button #1330

hahn-kev opened this issue Dec 20, 2024 · 0 comments · Fixed by #1376
Assignees
@rmunn
Labels
bug Something isn't working 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related Good first issue not too difficult, limited scope

Comments

@hahn-kev
Copy link
Collaborator

Describe the bug
both dialogs don't have an explicit close button, you can click outside the dialog to close it but that's not obvious

Expected behavior
There should be an X in a corner to close a dialog
@hahn-kev hahn-kev added bug Something isn't working 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related labels Dec 20, 2024
@hahn-kev hahn-kev added the Good first issue not too difficult, limited scope label Jan 8, 2025
@rmunn rmunn self-assigned this Jan 14, 2025
@rmunn rmunn mentioned this issue Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmunn rmunn

Labels
bug Something isn't working 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related Good first issue not too difficult, limited scope
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add close buttons to history & activity views sillsdev/languageforge-lexbox
2 participants
@rmunn @hahn-kev