-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: generate .fwdata file from lexbox? #631
Comments
A tech support user wrote to us saying:
If we made this feature generally available (with good UI), not just to admins, that might go a long way towards responding to this user's request. |
True, however that users problem would better be solved with #695 which would let him pull changes without pushing, which is what he wants to do right now. |
We think there is strong merit to adding this feature even without an user
requesting the ability to download a fwdata file from lexbox.
…On Sat, Apr 13, 2024 at 2:13 AM Kevin Hahn ***@***.***> wrote:
True, however that users problem would better be solved with #695
<#695> which would
let him pull changes without pushing, which is what he wants to do right
now.
—
Reply to this email directly, view it on GitHub
<#631 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2I6KPK4OWCLQ355EBAG6LY5AW6FAVCNFSM6AAAAABEE676RSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGM4DANJSGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I took a look at the FLExBridge code. The static PutHumptyTogetherAgain method that reassembles a .fwdata file from its component parts is an internal method, however FLExBridge exposes its internals to LfMergeBridge, which we're already using. All we would need to change to make this workable would be to add the following static method in LfMergeBridge: public static void PutHumptyTogetherAgain(IProgress progress, bool writeVerbose, string mainFilePathname)
{
FLExProjectUnifier.PutHumptyTogetherAgain(progress, writeVerbose, mainFilePathname);
} That would allow us to use the PutHumptyTogetherAgain method from a console tool that uses the LfMergeBridge library, without touching the class permissions of FLExProjectUnifier. We would then just need to release a new version of the LfMergeBridge NuGet package and we'd be able to write a command-line tool that does what we need, with no risk to FLEx or WeSay since we're not touching the interfaces they use at all. |
As discussed the CLI will be part of the FLExBridge repo. It should be packaged/available in a FLExBridge installation. |
PR is now over in FLExBridge repo at sillsdev/flexbridge#403. The GHA workflow doesn't build installers for PRs currently, so I can't easily verify that the binaries are being included in the FLExBridge installer package. I suspect, for now, that they aren't, and that I'll need to modify the .wix files to include them, but I don't expect to be able to test that until that PR is reviewed and merged. In the meantime, you can test the tools by running |
Per meeting discussion the tool will go into the FlexBridge repo and we will have a workflow to build the exe for us to download, if in the future Jason wants to include it with the FW installer then it's already in place to do that. |
As an admin-only tool, if there's a Send/Receive problem with a project, we might sometimes want to download an .fwdata file from the repo. The actual logic for how the .fwdata file gets put together from pieces is extremely simple and wouldn't be too hard to do. Question is, how useful would it be? I have a feeling that it would turn out to be immensely useful in many ways, but we'll see.
The text was updated successfully, but these errors were encountered: