Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review exposure of data in request contexts #18

Open
jthomerson opened this issue Feb 26, 2019 · 0 comments
Open

Review exposure of data in request contexts #18

jthomerson opened this issue Feb 26, 2019 · 0 comments
Assignees
@yokuze
Milestone
1.0.0

Comments

@jthomerson
Copy link
Member

See

lambda-express/src/Request.ts

Lines 254 to 255 in 1139fa8

// TODO: should something be done to limit what's exposed by these contexts? For
// example, make properties read-only and don't expose the callback function, etc.

And

lambda-express/src/Request.ts

Line 279 in 1139fa8

// TODO: this isn't a deep clone - does it need to be?

@jthomerson jthomerson added this to the 1.0.0 milestone Feb 26, 2019
yokuze added a commit to yokuze/lambda-express that referenced this issue Mar 7, 2019
@yokuze
fix: freeze lambda context object (silvermine#18)
95edf6f
yokuze added a commit to yokuze/lambda-express that referenced this issue Mar 7, 2019
@yokuze
fix: freeze lambda context object (silvermine#18)
b2c7dac
jthomerson added a commit that referenced this issue Mar 15, 2019
@jthomerson
Merge pull request #29 from yokuze/restrict_fn_context_obj_18
c739611 
fix: freeze lambda context object (#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yokuze yokuze

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@jthomerson @yokuze