Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off 4.13 ci cron + resolve red builds #235

Closed
4 tasks done
emteknetnz opened this issue May 2, 2024 · 7 comments
Closed
4 tasks done

Turn off 4.13 ci cron + resolve red builds #235

emteknetnz opened this issue May 2, 2024 · 7 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented May 2, 2024

CMS 4.13 is now in the "Security fix only" phase. The need for keeping the builds green there has been considerably reduced.

Acceptance criteria

  • PR to turn off the ci cron for 4.13 builds - see dispatch-ci
  • Resolve any outstanding broken builds on 4.13
  • Update security release process to manually re-run ci on 4.13 builds that may be affected by high impact patch on the day or release
  • Update security fix section in regular release process

PRs

@GuySartorelli
Copy link
Member

PRs merged, reassigning to Steve 'cause Rhino doesn't look happy still

@GuySartorelli
Copy link
Member

PRs merged. Reassigning to Steve to check if Rhino is happy.

@GuySartorelli
Copy link
Member

Reopening - The CMS 4 CI is still being dispatched. See https://github.com/silverstripe/silverstripe-blog/actions/runs/9281371462/job/25537243483 as an example

It does output the message to say it's skipping it

Workflow is configured to not dispatch workflow for branches on previous major. Exiting.

But then it still continues processing anyway

branch is 3.12

@GuySartorelli GuySartorelli self-assigned this May 31, 2024
@emteknetnz
Copy link
Member Author

Assigning back to Guy to confirm all is working correctly

@GuySartorelli
Copy link
Member

I'll green-ify the remaining 4.13 CI builds once we can see that the cron has stopped running. That will require #267 to be resolved.

@GuySartorelli
Copy link
Member

That was merged - now need to wait for the weekend to see if cron runs.

@GuySartorelli
Copy link
Member

Crons now skipping CMS 4 as expected. I'll tidy up the remaining CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants