You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should probably also add this to the testing recipe so that it's included in installer and sink installations by default as a dev dependency, which facilitates running it locally.
Acceptance criteria
All supported modules have a php linting step that runs php-parallel-lint
The linter is run against all source code, tests, and _config.php if one exists
If we had a syntax error, I would expect PHPUnit to start failing. I can't remember any time where our we had a syntax error that manage to sneak through this way.
Not necessarily against this, but it seems like a very marginal improvement.
We use PHP Code Sniffer, but that’s not a linter. Notably, it won’t pick up on syntax errors.
We should add https://github.com/php-parallel-lint/PHP-Parallel-Lint to CI to help avoid syntax errors from sneaking in.
Notes
Acceptance criteria
_config.php
if one existsPRs
The text was updated successfully, but these errors were encountered: