Skip to content
This repository has been archived by the owner on Jun 15, 2022. It is now read-only.

Migrate emteknetnz gha actions #36

Closed
23 tasks done
emteknetnz opened this issue May 23, 2022 · 7 comments
Closed
23 tasks done

Migrate emteknetnz gha actions #36

emteknetnz opened this issue May 23, 2022 · 7 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented May 23, 2022

Create new repos on silverstripe account with emtpy readme only, then fork repos to emteknetnz, and create PRs with copy pasted contents from gha versions so they can all be peer reviewed

I'm thinking we should retain the gha- prefix instead of the github-actions- prefix, and also split the exsiting 'workflow_call' style github-actions-ci-ci repo to a pair of actions to be consistent:

  • gha-ci
  • gha-update-js (ditch the -deps suffix since it also does a build)

ACs

  • gha-run-tests
  • gha-pull-request
  • gha-tag-release
  • gha-auto-tag
  • gha-generate-matrix
  • gha-ci
  • gha-update-js
  • gha-keepalive
  • Update readme instructions for each so it's clear how to use them
  • Add auto-tag action to each workflow in each action
  • Update actions/workflows to use silverstripe @v1 versions
  • Tag release 1.0.0 of each module
  • Validate that errors systematically failed the build
  • Validate that pass string input variables and pull request title though env variables
  • Validate that Pin third party actions to specific shas works

PRs

The following will be handled with silverstripe/gha-ci#4:

@GuySartorelli
Copy link
Member

@emteknetnz Can you please add a meaningful description to each of the gha repositories? It will make it a lot easier to know at a glance what each repo is for.

@emteknetnz
Copy link
Member Author

Descriptions are in the readme.md of each pull-request

@GuySartorelli
Copy link
Member

6 months down the track, nobody will want to open each repo to remember, for example, the distinction between gha-auto-tag and gha-tag-release or what the purpose of gha-pull-request is. It's good practice to have a meaningful description for repositories.

@emteknetnz
Copy link
Member Author

Oh, are you referring to text field in the actual github repo i.e.

image
?

@GuySartorelli
Copy link
Member

Yes, that's the one. Sorry, I should have been more explicit.

@emteknetnz
Copy link
Member Author

Have added descriptions on the silverstripe account repos

@GuySartorelli
Copy link
Member

@emteknetnz PRs merged. I think the next step is for you to create a 1 branch for each repo and create a PR that swaps from using @main to @v1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants