Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid/validation error form fields styling #1117

Open
sachajudd opened this issue Sep 23, 2020 · 0 comments
Open

Invalid/validation error form fields styling #1117

sachajudd opened this issue Sep 23, 2020 · 0 comments

Comments

@sachajudd
Copy link
Contributor

sachajudd commented Sep 23, 2020

Invalid or validation error styles on form fields currently do not match DSM designs.
Currently throughout the CMS we are seeing inconsistent patterns and alerts being used as field validation errors e.g
image

We also need to drop out the role attribute as part of this selector. These errors shouldn't have that attribute, and it would be best to keep it out of the selector if possible.

See form invalid designs for:

  • Invalid fields
  • Validation errors (labels and descriptions)
  • Select drop downs
  • Checkboxes and radios

Related: #863 & silverstripe/silverstripe-cms#2081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants