You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently LeftAndMain is bloated with logic for setting up formschema, but that isn't needed by most of its subclasses. This should be moved into its own class so the logic is only available where it's needed, and to make LeftAndMain easier to maintain.
Methods, properties, and configuration required for formschema functionality are moved from LeftAndMain to the new class (see this comment for recommendations about this)
ModalController is a subclass of the new controller
ModalController handles the routes which currently require creating a singleton of LeftAndMain for formschemas
Any controller in supported modules that currently subclasses LeftAndMain but only needs the formschema logic is made to subclass the new class instead (e.g. LinkFieldController)
Documentation is updated to indicate best practice for form schema controllers
Currently
LeftAndMain
is bloated with logic for setting up formschema, but that isn't needed by most of its subclasses. This should be moved into its own class so the logic is only available where it's needed, and to makeLeftAndMain
easier to maintain.Related
Notes
Acceptance Criteria
FormSchemaController
class is created, and is a subclass ofAdminRouteController
(see Refactoradmin/*
routing logic fromLeftAndMain
into its own abstract class #1761)LeftAndMain
to the new class (see this comment for recommendations about this)ModalController
is a subclass of the new controllerModalController
handles the routes which currently require creating a singleton ofLeftAndMain
for formschemasLeftAndMain
but only needs the formschema logic is made to subclass the new class instead (e.g.LinkFieldController
)PRs
CMS 5 PRs
After merging reassign to Guy so they can merge up and rebase the CMS 6 PRs
CMS 6 PRs
Kitchen sink CI
The text was updated successfully, but these errors were encountered: