-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor logic for sections that deal with only a single record out of LeftAndMain
into its own class
#1764
Comments
This was referenced Oct 24, 2024
Open
Open
Open
@GuySartorelli even though it's draft, I've started by reviewing the CMS 6 framework PR first as that could change the CMS 5 PRs |
GuySartorelli
assigned emteknetnz and GuySartorelli and unassigned GuySartorelli and emteknetnz
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Most subclasses of
LeftAndMain
deal with more than one record at a time - be itModelAdmin
which handles multiple records in aGridField
, orCMSMain
which deals with multiple records in a hierarchical structure.The logic in
LeftAndMain
which is intended for sections that only edit a single record should be abstracted out into its own abstract class.Related
Notes
Acceptance criteria
SingleRecordAdmin
class is created, which is a subclass ofLeftAndMain
- already handled by RefactorAdminRootController
checks for (non-abstract) subclasses of the new class instead of subclasses ofLeftAndMain
to set up routing rulesadmin/*
routing logic fromLeftAndMain
into its own abstract class #1761LeftAndMain
to the new classCMSProfileController
,SiteConfigLeftAndMain
, and any other controllers in supported modules which only edit a single record are made subclasses of this new classCMSProfileController
,SiteConfigLeftAndMain
, etc are made generic and are implemented in the new class directlyPRs
CMS 5 PRs
CMS 6 PRs
kitchen sink ci
The text was updated successfully, but these errors were encountered: