Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image with caption should use <figure> and <figcaption> #1318

Open
kinglozzer opened this issue Jan 11, 2023 · 2 comments
Open

Image with caption should use <figure> and <figcaption> #1318

kinglozzer opened this issue Jan 11, 2023 · 2 comments

Comments

@kinglozzer
Copy link
Member

kinglozzer commented Jan 11, 2023

Currently the markup is roughly:

<div class="captionImage leftAlone">
    <img src="people.jpg" width="123" height="456" alt="Team photo" />
    <p class="caption leftAlone">From left to right: John, Karen, Richard</p>
</div>

This should be represented by <figure> and <figcaption> elements:

<figure class="captionImage leftAlone">
    <img src="people.jpg" width="123" height="456" alt="Team photo" />
    <figcaption class="caption leftAlone">From left to right: John, Karen, Richard</figcaption>
</figure>

The same applies to captions added to embedded videos.

PRs

@kinglozzer
Copy link
Member Author

Initial PR: #1321. I need to rebase it and do a matching PR for framework

@GuySartorelli
Copy link
Member

Are you still interested in this @kinglozzer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants