-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AVIF image conversion #491
Comments
Do earlier PHP releases support AVIF through Imagick, if ImageMagick is compiled with support for it? |
How is this defined? You mention PHP < 8.1 doesn't support AVIF, but AVIF is just a file. PHP shouldn't care what the format is of a file - that's up to implementations within PHP to decide how to handle it. In other words someone could define a custom converter using the conversion API defined in #489 that works in PHP 8.0. I wouldn't want core to say "Yeah but because you're not on PHP >= 8.1 you can't use that." It would be better, I think, for the conversion API to have a method like |
Not sure ... maybe. I guess one thing we could do is just make support for AVIF one extra module you need to install and its your job to figure if your system supports it our not. The downside is that this requires a conscious choice from developer. If we ship it in some common module, then you will automatically get it and your site might start generating AVIF images without you even having to think about it.
Just because, you have PHP8.1, doesn't mean you can generate AVIF image. I tried enabling AVIF locally in my environment with PHP8.1. My PHP8.1 version wasn't compiled with AVIF support because a required binary doesn't ship by default with Ubuntu. I was still able to upload AVIF image to the CMS and use them in WYSIWYG. However, the CMS always outputted the original image even when I was telling it to resize it. I think we would need to check that a specific method exists. Maybe in the "output images in multiple formats" module we can have conditional check to detect if AVIF is supported and that could call some lower level API like |
Shouldn't this just be handled as a manipulation by the Image Manipulation backend? At least that is how we have implemented this. Both GD, ImageMagick and libvips support avif and webp conversion with the correct versions, and all of these can be used as image manipulation backends via the intervention image drivers. |
As a project owner I want access to the latest and greatest image formats.
Acceptance criteria
Note
The text was updated successfully, but these errors were encountered: