Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File::BackLinkTracking() - Implement PolymorphicManyManyList to replace ArrayList #575

Open
sabina-talipova opened this issue Oct 12, 2023 · 0 comments
Open

File::BackLinkTracking() - Implement PolymorphicManyManyList to replace ArrayList #575

sabina-talipova opened this issue Oct 12, 2023 · 0 comments
Labels
type/api-break type/enhancement
Milestone
Cleanup later

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 12, 2023 •
edited by GuySartorelli
Loading

Description

In File, the BackLinks relationship should be turned into a polymorphic many_many relationship (using a many_many through relation as documented).

File::BackLinksTracking() would then be redundant - you'd just get the backlinks directly from the polymorphic relation.

See:

silverstripe-assets/src/File.php

Line 1304 in 27000f1

// @todo - Implement PolymorphicManyManyList to replace this

Related
This was referenced Oct 12, 2023
Closed
Merged
@GuySartorelli GuySartorelli mentioned this issue Oct 24, 2023
Open
@GuySartorelli GuySartorelli added this to the Silverstripe CMS 6 milestone Oct 24, 2023
@GuySartorelli GuySartorelli changed the title TODO: File::BackLinkTracking() - Implement PolymorphicManyManyList to replace ArrayList File::BackLinkTracking() - Implement PolymorphicManyManyList to replace ArrayList Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/api-break type/enhancement
Projects
None yet
Milestone
Cleanup later
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova