Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings allow for groups to be assigned to content review that do not have permission to view page admin #110

Open
NightJar opened this issue May 8, 2019 · 2 comments

Comments

@NightJar
Copy link
Contributor

NightJar commented May 8, 2019

When editing the SiteConfig in the CMS for a site with Content Review enabled, there are options to assign both individual users (plural) and groups of users to content review.

When assigning users, only users with permission to edit pages show up as possibilities.

However when assigning groups, all groups show up, regardless of permissions. This makes it possible to assign users that can e.g. only see the files section to get notifications about content reviews for pages.

@robbieaverill
Copy link
Contributor

IMO if people want to do that, that's OK.

@NightJar
Copy link
Contributor Author

NightJar commented May 8, 2019

I think the behaviour should be consistent, however it is super minimal impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants