SolrIndex->getRequireFiltersComponent does not sanitise class names

[tyrannosaurusjames]

I am receiving an error from Solr when trying to filter results on the Content field of SiteTree. Specifically:

org.apache.solr.common.SolrException: undefined field SilverStripeCMSModelSiteTree_Content

I am adding the filter by using the SearchQuery class, like so: (simplified example)

$query = new SearchQuery();
$query->addFilter(SiteTree::class . '_Content', 'filter text');

$index->search($query);

It looks like this issue is caused due to a missing call to SolrIndex->sanitiseClassName in SolrIndex->getRequireFiltersComponent.

You can see an example of where the field name is being sanitised correctly in SolrIndex->getExcludeFiltersComponent here: https://github.com/silverstripe/silverstripe-fulltextsearch/blob/master/src/Solr/SolrIndex.php#L965-L970 which is what lead me to believe it was missing in getRequireFiltersComponent

Edit: I am using silverstripe/fulltextsearch version 3.4.1 but this issue appears to affect newer versions too

[tyrannosaurusjames]

I should note I can workaround this issue by sanitising the class name myself before I call SearchQuery->addFilter, e.g.

$query = new SearchQuery();
$fieldName = SiteTree::class . '_Content';
$sanitisedFieldName = (new MySolrIndex())->sanitiseClassName($fieldName);

$query->addFilter($sanitisedFieldName, 'filter text');

[emteknetnz]

Related #269