From 379fda091b63db890abeb18fb7143d67d1f9f34a Mon Sep 17 00:00:00 2001 From: Peter Schiffer <3899107+pschiffe@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:01:35 +0100 Subject: [PATCH] FIX `HTTPBulkToolsResponse.addSuccessRecords()` fn This function was trying to merge 2 arrays with PHP fn `array_push()` which was failing if the second parameter was array as well. This fix replaces `array_push()` with `array_merge()` fn. Resolves #187 --- src/BulkTools/HTTPBulkToolsResponse.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BulkTools/HTTPBulkToolsResponse.php b/src/BulkTools/HTTPBulkToolsResponse.php index 7a2ee3d..c6baf21 100644 --- a/src/BulkTools/HTTPBulkToolsResponse.php +++ b/src/BulkTools/HTTPBulkToolsResponse.php @@ -197,7 +197,7 @@ public function addSuccessRecord($record) */ public function addSuccessRecords(SS_List $records) { - array_push($this->successRecords, $records->toArray()); + $this->successRecords = array_merge($this->successRecords, $records->toArray()); return $this; }