Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 5.2.0-beta1. Regression test: LinkField UI/UX enhancements #255

Open
sabina-talipova opened this issue Mar 14, 2024 · 4 comments
Open

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Mar 14, 2024

Description

There are some failed tests that is not bugs or problem. They are more desired enhancements that can be done in LinkField.
Here the list of failed tests:

  • Open in new window should change to open in new tab
  • I can't see an external icon with the My Page link. it's expected to show as it has been set to open in a new tab.
  • Phone Link validation: I should not be able to add letters in the text field. There's no error message when I try to create invalid phone link.

Note:

Perhaps we should think about the expediency of making these changes and if not then close this ticket.

@GuySartorelli
Copy link
Member

I can't see an external icon with the My Page link

Do you mean on the front-end?
This would be up to the developers to add theming for that. There's no icon for this added by default in the template.

@GuySartorelli
Copy link
Member

Phone Link validation

I've removed it from this card. See #252
We explicitly decided to only have phone number be required for now - additional validation (if we add any) will be under that card.

@maxime-rainville
Copy link

Open in new window should change to open in new tab

Looking at the official spec, it doesn't say whether it should be a new tab or a new window.

Mozilla just list this description as:

_blank: Usually a new tab, but users can configure browsers to open a new window instead.

I vaguely remember that when Firefox first introduced tab browsing 2+ decades ago, you used to be able to give it a different attribute that would control if the link would open in a new tab or a new window (yes, I'm that old).

My gut feeling is that most users will understand "tab" and "window" to be functionally the same.

I can't see an external icon with the My Page link. it's expected to show as it has been set to open in a new tab.

I don't know that we want to have a "this link will open in a new tab" icon. This would probably cause confusing with "External Link" icon.

@maxime-rainville
Copy link

I'm running a quick internal survey to see if there's a net preference "open in new window" and "open in new tab".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants