You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some failed tests that is not bugs or problem. They are more desired enhancements that can be done in LinkField.
Here the list of failed tests:
Open in new window should change to open in new tab
I can't see an external icon with the My Page link. it's expected to show as it has been set to open in a new tab.
Phone Link validation: I should not be able to add letters in the text field. There's no error message when I try to create invalid phone link.
Note:
Perhaps we should think about the expediency of making these changes and if not then close this ticket.
The text was updated successfully, but these errors were encountered:
I've removed it from this card. See #252
We explicitly decided to only have phone number be required for now - additional validation (if we add any) will be under that card.
Open in new window should change to open in new tab
Looking at the official spec, it doesn't say whether it should be a new tab or a new window.
Mozilla just list this description as:
_blank: Usually a new tab, but users can configure browsers to open a new window instead.
I vaguely remember that when Firefox first introduced tab browsing 2+ decades ago, you used to be able to give it a different attribute that would control if the link would open in a new tab or a new window (yes, I'm that old).
My gut feeling is that most users will understand "tab" and "window" to be functionally the same.
I can't see an external icon with the My Page link. it's expected to show as it has been set to open in a new tab.
I don't know that we want to have a "this link will open in a new tab" icon. This would probably cause confusing with "External Link" icon.
Description
There are some failed tests that is not bugs or problem. They are more desired enhancements that can be done in LinkField.
Here the list of failed tests:
open in new tab
Phone Link validation: I should not be able to add letters in the text field. There's no error message when I try to create invalid phone link.Note:
Perhaps we should think about the expediency of making these changes and if not then close this ticket.
The text was updated successfully, but these errors were encountered: