Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract re-usable components to NPM module #215

Open
4 tasks
Cheddam opened this issue Jun 24, 2019 · 0 comments
Open
4 tasks

Extract re-usable components to NPM module #215

Cheddam opened this issue Jun 24, 2019 · 0 comments

Comments

@Cheddam
Copy link
Member

Cheddam commented Jun 24, 2019

A number of pieces that make up the MFA UIs could be shared between the base module and implementations (TOTP / WebAuthn):

  • Buttons
  • Icons
  • Layouts
  • Etc.

We should refactor these into clear functional components, and shift them into an NPM module that each bundle can pull in as required. We should also set up a Storybook for this shared module to make modifying the components in isolation easier, and to allow simpler re-use by other developers building their own MFA methods.

ACs:

  • An NPM module is created with Storybook configured
  • Each section of the MFA UIs is reviewed for potential extraction
  • Where sensible, atoms / molecules are extracted to the NPM module as functional components
  • The newly extracted elements are applied to the MFA bundles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants