Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected responses leave just loading spinner showing #431

Open
matt-in-a-hat opened this issue May 30, 2021 · 1 comment
Open

Unexpected responses leave just loading spinner showing #431

matt-in-a-hat opened this issue May 30, 2021 · 1 comment
Labels

Comments

@matt-in-a-hat
Copy link

If the server returns an error when loading then no error is shown and the spinner just remains. E.g. if it sends a request to
/Security/changepassword/mfa/login/totp but that request returns <h1>429 - Too many requests</h1> (if you've hit the Security controller too much in a period), it has the console error SyntaxError: Unexpected token <.

Ideally this would display something to the user, even if it's "An error occurred, please refresh"

Using silverstripe/mfa:4.2.2
and silverstripe/totp-authenticator:4.1.1

@brynwhyman
Copy link

Hmm, sounds like this might be a follow on issue since this PR was implemented: #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants