Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS4. Minor. New site title not displayed at top left after "Save". #102

Open
SpiritLevel opened this issue Dec 15, 2018 · 3 comments
Open

Comments

@SpiritLevel
Copy link

If you edit Site title in Settings and click "Save", the Site title appearing in the top left of the CMS is not updated; it does get updated upon page reload, though.

@maxime-rainville
Copy link

maxime-rainville commented Dec 19, 2018

I guess the problem here is that saving the SiteConfig is done via an AJAX call and the site title is loaded via rendered templates.

My thinking here is that this is probably not worth fixing:

  • This would involved adding some clunky hook to this single form ;
  • This is not something most editors will do very often or have access to do ;
  • The change gets reflected correctly as soon as you navigate to a different controller.

I'm happy to hear a contrarian view.

@kinglozzer
Copy link
Member

I’m sure we used to use an HTTP header (something along the lines of X-Reload: 1) to signal that the browser should perform a hard refresh after saving... then again perhaps I dreamt it 😅

@robbieaverill
Copy link
Contributor

Yeah, we could use a PJAX fragment reload to achieve this if we wanted to. I agree with the triaging though that it's pretty low impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants