Display rules not duplicating correctly with Userforms page duplication

[ebakernz]

When I duplicate a UserDefinedForm page that has some form fields with display rules set, the new form display rule reference to the ConditionalFieldID is still referring to the original form field ID.

On the new form page in the CMS, the field's display rules conditional field dropdown appears to be set to the first field in the list. When the new form is published, the first field in the display rule - conditional field dropdown is saved as the value, which is incorrect. This is because the dropdown has no default value, and is not carrying over the value to the new instance of the form.

To replicate:
Create form, add field with a conditional / display rule and some fields above the conditional field, eg:

Duplicate the form page and inspect the display rules.

Inspect the database table for EditableCustomRule
New form's conditional field ID (line 2) is same as original form's field.

Publish form page, inspect database table EditableCustomRule_Live
Conditional Field ID is now referencing the first value in the dropdown (incorrect)

The issue can be fixed in the CMS by updating display rules to correct conditional field, publish.
Database is now referring to correct field.

However, it would be better if duplicating the form, also duplicated the display rules correctly.

[emteknetnz]

Related #1115