$owns broken when using versioning without stages

[kinglozzer]

Versions

4.8.1 - 4.x-dev (possibly earlier than 4.8.1, that’s all I tested)

Problem

When using versioning without stages (Versioned::class.'.versioned'), owned objects won’t be published.

Reproduction steps

Add the following code, dev/build then create an object and add an image. The image won’t be published when you save the object.

<?php

namespace App\Model;

use SilverStripe\Assets\Image;
use SilverStripe\ORM\DataObject;
use SilverStripe\Versioned\Versioned;

class TestObject extends DataObject
{
    private static $table_name = 'TestObject';

    private static $db = [
        'Title' => 'Varchar(255)'
    ];

    private static $has_one = [
        'Image' => Image::class
    ];

    private static $owns = [
        'Image'
    ];

    private static $extensions = [
        Versioned::class . '.versioned'
    ];
}

<?php

namespace App\Admin;

use App\Model\TestObject;
use SilverStripe\Admin\ModelAdmin;

class TestObjectAdmin extends ModelAdmin
{
    private static $managed_models = [
        TestObject::class
    ];

    private static $menu_title = 'Test object';

    private static $url_segment = 'test-object';
}

[kinglozzer]

Adding an && $record->hasStages() check to this line appears to solve it:

silverstripe-versioned/src/VersionedGridFieldItemRequest.php

Line 104 in a0a216c

$ownerIsVersioned = $record && $record->hasExtension(Versioned::class);

I think that’s okay as a fix? It changes the logic from “prevent publish if the record is versioned” to “prevent publish if the record is versioned with stages”. If the record is versioned without stages, there’s no reason to prevent a publish as the save action updates “live” content immediately anyway.