Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of RingExtraction #2091

Open
kif opened this issue Mar 8, 2024 · 3 comments · May be fixed by #2121
Open

Make use of RingExtraction #2091

kif opened this issue Mar 8, 2024 · 3 comments · May be fixed by #2121

Comments

@kif
Copy link
Member

kif commented Mar 8, 2024

Follow-up of #2082

As written previously, such a class is likely to be used at several places:

  • in pyFAI-calib2 where the code is available in pyFAI.gui.helper.RingExtractor.RingExtractorThread
  • in pyFAI-calib where the code is available in pyFAI.gui.cli_calibration.AbstractCalibration.extract_cpt
@kif
Copy link
Member Author

kif commented Mar 8, 2024

Also, extract SingleGeometry and expose it it in its own sub-module

@emilymassahud
Copy link
Contributor

just saw you merged the other branch; cool :)
I'll work on this next.

@emilymassahud
Copy link
Contributor

@kif , I think that in order to make RingExtraction work for the calib guis, there'll have to be some larger refactoring of code.
Both are rather intertwined with the PeakPicker class, so I'll have to take that into account somehow. Perhaps I can add the option to add a PeakPicker instance instead of a SingleGeometry as a class attribute, so we can unify it all...
I also noticed that in the gui there is the option of choosing other methods for extraction (blob and watershed) so I'll work on including those options to RingExtraction too.
Very welcome to hearing ideas from you too, if you have them.
I'll push what I've done but mark as work in progress as I go so you can check it out and give input as well.

@emilymassahud emilymassahud linked a pull request Apr 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants