Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[worker] JSON serialization version 4 #2233

Open
1 of 7 tasks
kif opened this issue Jul 5, 2024 · 2 comments
Open
1 of 7 tasks

[worker] JSON serialization version 4 #2233

kif opened this issue Jul 5, 2024 · 2 comments
Assignees

Comments

@kif
Copy link
Member

kif commented Jul 5, 2024

The main difference with version 3 is the separation of the description of the geometry in a poni structure instead of having it flat in the main.
Before:

{
'version': 3,
'poni_version': 2.1,
'detector': 'detector',
'detector_config': {'pixel1': 1e-4, 'pixel2': 1e-4},
[...]
}

After:

{
'version': 4,
poni: {
    'poni_version': 2.1,
    'detector': 'detector',
    'detector_config': {'pixel1': 1e-4, 'pixel2': 1e-4},
   [...]
},
[...]
}

Impacts every place where workers are used:

  • worker
  • io.integration_config --> doc goes there
  • diffmap
  • gui.diffmap_widget
  • gui.IntegrationDialog
  • test.test_worker
  • app.integrate
@kif kif added the enhancement label Jul 5, 2024
@kif kif changed the title Implement worker description version 4 when serializing in JSON [worker] JSON serialization version 4 Jul 5, 2024
@EdgarGF93
Copy link
Collaborator

EdgarGF93 commented Jul 22, 2024

#2249 work in progress

@kif
Copy link
Member Author

kif commented Sep 25, 2024

TODO: check the progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants