Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eight sample orientations #2333

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

eight sample orientations #2333

wants to merge 3 commits into from

Conversation

EdgarGF93
Copy link
Collaborator

@EdgarGF93 EdgarGF93 commented Nov 13, 2024 •
edited
Loading

Wait to merge #2324

@EdgarGF93
Copy link
Collaborator Author

EdgarGF93 commented Nov 13, 2024 •
edited
Loading

Now, the grazing incidence module covers the 8 possible orientations of the sample:
image
(check the different positions/orientations of the photodiode wire)

Sample orientation= 1 -> 4 (+90 degrees rotation)
Sample orientation=5 (mirror transf. of SO=1)
Sample orientation=5 -> 8 (-90 degrees rotation) (6 is the mirror transf. of 2, 7 of 3, and 8 of 4)

@EdgarGF93 EdgarGF93 added the ready to merge Please review label Nov 13, 2024
Edgar Gutierrez Fernandez added 2 commits November 13, 2024 16:27
@EdgarGF93 EdgarGF93 added work in progress Don't review and removed ready to merge Please review labels Nov 13, 2024
@EdgarGF93
Copy link
Collaborator Author

Needs #2349 to add the eight orientations for the numexpr calculation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progress Don't review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EdgarGF93